Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDA flags to draco_info report #1135

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Add CUDA flags to draco_info report #1135

merged 5 commits into from
Sep 16, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Sep 15, 2021 •
edited
Loading

Background

  • Update the draco_info command so that information about Cuda is also printed.

Description of changes

  • Fix a bug in the draco_info report that removed leading slashes for compiler paths.
  • Also wrap the fully qualified path to mpirun
  • Move some names to "prior contributors" section of the author list.
  • Minor clean-up in cdi files.

Example output

draco-info-out

Status

@KineticTheory
Add CUDA flags to draco_info report
71c898c 
+ Fix a bug in the `draco_info` report that removed leading slashes for compiler paths.
+ Also wrap the fully qualified path to `mpirun`
+ Move some names to "prior contributors" section of the author list.
+ Minor clean-up in cdi files.
@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Sep 15, 2021
@KineticTheory KineticTheory self-assigned this Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #1135 (c58faee) into develop (3b81b75) will decrease coverage by 0.0%.
The diff coverage is 75.0%.

@@            Coverage Diff            @@
##           develop   #1135     +/-   ##
=========================================
- Coverage     89.0%   89.0%   -0.1%     
=========================================
  Files          374     374             
  Lines        19255   19263      +8     
=========================================
+ Hits         17151   17155      +4     
- Misses        2104    2108      +4

@KineticTheory KineticTheory changed the title WIP: Add CUDA flags to draco_info report Add CUDA flags to draco_info report Sep 15, 2021
@KineticTheory KineticTheory changed the title Add CUDA flags to draco_info report WIP: Add CUDA flags to draco_info report Sep 15, 2021
KineticTheory
KineticTheory commented Sep 15, 2021
View reviewed changes
Copy link
Collaborator Author

@KineticTheory KineticTheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken logic

src/diagnostics/draco_info.cc Outdated Show resolved Hide resolved
@KineticTheory KineticTheory changed the title WIP: Add CUDA flags to draco_info report Add CUDA flags to draco_info report Sep 15, 2021
@KineticTheory
Copy link
Collaborator Author

@RyanWollaeger Can you review and merge this PR?

@RyanWollaeger
Copy link
Contributor

@KineticTheory Will do.

RyanWollaeger
RyanWollaeger approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanWollaeger RyanWollaeger merged commit 7cd5b16 into lanl:develop Sep 16, 2021
@KineticTheory KineticTheory deleted the di-cuda-flags branch September 16, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanWollaeger RyanWollaeger RyanWollaeger approved these changes

Assignees

@KineticTheory KineticTheory

Labels
enhancement
Projects
None yet
Milestone
Draco-7_12_0
Development

Successfully merging this pull request may close these issues.
2 participants
@KineticTheory @RyanWollaeger